This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: [#9439] Composer emits "input parameters" from dialog interface with external references instead of simple types; breaking PVA#9448
Merged
tracyboehrer merged 4 commits intomainfrom Jan 19, 2023
Conversation
ceciliaavila
requested review from
VamsiModem,
a-b-r-o-w-n,
benbrown,
boydc2014,
cwhitten,
natalgar,
srinaath and
tdurnford
as code owners
anishprasad01
added
the
Support-P0
tracyboehrer
removed request for
VamsiModem,
a-b-r-o-w-n,
benbrown,
boydc2014,
cwhitten,
natalgar,
srinaath and
tdurnford
tracyboehrer
approved these changes
Jan 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the input parameters of the dialog to be simple types in the uiOptions.ts class.
It also fixes a unit test to consider the new types.
Task Item
Fixes #9439
Screenshots
These images show a Composer skill bot working with a Composer and a PVA root bots.
