Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed shrinking of tab icon on sidecar docs page. #1557

Merged
merged 1 commit into from May 10, 2019

Conversation

Projects
None yet
4 participants
@tonyanziano
Copy link
Contributor

commented May 9, 2019

Before:
image

After:
image

@cwhitten

This comment has been minimized.

Copy link
Member

commented May 10, 2019

The failing test in CI is odd. It seems unrelated.

@justinwilaby

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

I fixed the logic that fails the unit test here: d9ae26d

@cwhitten

This comment has been minimized.

Copy link
Member

commented May 10, 2019

Ah, thank you @justinwilaby.

@corinagum

This comment has been minimized.

Copy link
Member

commented May 10, 2019

This change is awesome. The old icons bothered me a lot. :D

@tonyanziano tonyanziano force-pushed the toanzian/fix-icon branch from 7c417d8 to a6b6ac1 May 10, 2019

@tonyanziano tonyanziano merged commit 3a71044 into master May 10, 2019

3 checks passed

Azure DevOps CI #59107 succeeded
Details
[experimental]Upload-package.json #59108 succeeded
Details
license/cla All CLA requirements met.
Details

@tonyanziano tonyanziano deleted the toanzian/fix-icon branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.