Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed App Update UX & Made Auto Updates Opt-In #1575

Merged
merged 1 commit into from Jun 6, 2019

Conversation

Projects
None yet
2 participants
@tonyanziano
Copy link
Contributor

commented May 14, 2019

Resolves #1408

===

Tests are WIP

This PR includes the following changes to app update logic:

  1. Auto update must be explicitly opted into now
  2. The app will always check for updates on startup, regardless of auto update or not
  3. If there are updates, and auto update is not enabled, the following modal will be shown:

image

(option 2 is always selected by default, and option 3 will enable auto updates)

Light

image

Dark

image

High Contrast

image

@tonyanziano tonyanziano force-pushed the toanzian/update-#1408 branch from 36ee355 to e4ac767 May 15, 2019

@tonyanziano tonyanziano marked this pull request as ready for review May 15, 2019

@cwhitten cwhitten changed the title Toanzian/update #1408 [HOLD] toanzian/update #1408 May 15, 2019

@tonyanziano tonyanziano changed the title [HOLD] toanzian/update #1408 [HOLD] Changed App Update UX & Made Auto Updates Opt-In May 15, 2019

@tonyanziano tonyanziano force-pushed the toanzian/update-#1408 branch 2 times, most recently from b5d4472 to ca122a2 Jun 5, 2019

@tonyanziano tonyanziano force-pushed the toanzian/update-#1408 branch from ca122a2 to 43f6e00 Jun 6, 2019

@tonyanziano tonyanziano changed the title [HOLD] Changed App Update UX & Made Auto Updates Opt-In Changed App Update UX & Made Auto Updates Opt-In Jun 6, 2019

@cwhitten cwhitten merged commit abd94f7 into master Jun 6, 2019

3 checks passed

Emulator-CI-PR #63015 succeeded
Details
[experimental]Upload-package.json #63016 succeeded
Details
license/cla All CLA requirements met.
Details

@cwhitten cwhitten deleted the toanzian/update-#1408 branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.