Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Add inspector support to protocolHandler#1617

Merged
stevengum merged 2 commits into
masterfrom
protocol-update
Jun 4, 2019
Merged

Add inspector support to protocolHandler#1617
stevengum merged 2 commits into
masterfrom
protocol-update

Conversation

@stevengum
Copy link
Copy Markdown
Member

Fixes #1567

Uses feedback on #1601

Changes

  • Add support for bfemulator://inspector.open
    • Open emulator in debug mode
    • Open emulator and connect to bot in debug mode
    • Add test for inspector.open, refactor test for livechat.open

Copy link
Copy Markdown
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :shipit:

@justinwilaby
Copy link
Copy Markdown
Contributor

I can confirm this feature works on a distribution build of the Emulator for Mac:
Screen Shot 2019-06-04 at 3 10 17 PM

@tonyanziano
Copy link
Copy Markdown
Contributor

Verified as well on Windows. 👍

@stevengum stevengum merged commit d1c6efe into master Jun 4, 2019
@stevengum stevengum deleted the protocol-update branch June 4, 2019 23:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bot Inspector] Open a inspector mode conversation via protocol

3 participants