Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inspector support to protocolHandler #1617

Merged
merged 2 commits into from Jun 4, 2019

Conversation

Projects
None yet
3 participants
@stevengum
Copy link
Member

commented Jun 4, 2019

Fixes #1567

Uses feedback on #1601

Changes

  • Add support for bfemulator://inspector.open
    • Open emulator in debug mode
    • Open emulator and connect to bot in debug mode
    • Add test for inspector.open, refactor test for livechat.open
@justinwilaby
Copy link
Contributor

left a comment

LGTM. :shipit:

@justinwilaby

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

I can confirm this feature works on a distribution build of the Emulator for Mac:
Screen Shot 2019-06-04 at 3 10 17 PM

@tonyanziano

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

Verified as well on Windows. 👍

@stevengum stevengum merged commit d1c6efe into master Jun 4, 2019

3 checks passed

Emulator-CI-PR #62744 succeeded
Details
[experimental]Upload-package.json #62745 succeeded
Details
license/cla All CLA requirements met.
Details

@stevengum stevengum deleted the protocol-update branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.