Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed OAuth card prompt flow #1660

Merged
merged 1 commit into from Jun 27, 2019

Conversation

Projects
None yet
2 participants
@tonyanziano
Copy link
Contributor

commented Jun 26, 2019

Fixes #1544

===

This will fix the issue users were having when trying to authenticate via an OAuth prompt card as seen in samples 18 and 24.

ngrok.ts has been rewritten so that instead of being a singleton, it is now a class that can be instantiated multiple times to represent individual ngrok instances.

This fix checks to see if ngrok is already running when generating the postback URL for the OAuth sign in flow. If ngrok is already running, then that ngrok URL is used as the postback URL, if not, we start up a separate ngrok instance solely for the purpose of generating a URL that can be used as the postback URL. If we started up the separate ngrok instance for OAuth, we tear it down once the token response is received from the Bot Framework token server.

@tonyanziano tonyanziano force-pushed the toanzian/auth branch from 01b96b8 to 1c089ca Jun 26, 2019

@justinwilaby
Copy link
Contributor

left a comment

:shipit:

@tonyanziano tonyanziano merged commit b41a4ee into master Jun 27, 2019

3 checks passed

Emulator-CI-PR #67440 succeeded
Details
[experimental]Upload-package.json #67441 succeeded
Details
license/cla All CLA requirements met.
Details

@tonyanziano tonyanziano deleted the toanzian/auth branch Jun 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.