Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1710] Fixed color contrast issues on welcome page. #1782

Merged
merged 1 commit into from Aug 27, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Aug 27, 2019

#1710

===

Affected areas:

  • (Light / Dark) Version header
  • (Light) My bots list entries

Version header (Light)

light_header

My bots list entries (Light)

light_bots

Version header (Dark)

dark_header

@tonyanziano tonyanziano force-pushed the toanzian/acc-#1710 branch from 600d958 to 6fdec75 Aug 27, 2019
Copy link
Member

corinagum left a comment

LGTM - left one comment

@@ -2,8 +2,8 @@
export const marginFix: string;
export const noBots: string;
export const recentBot: string;
export const recentBotPath: string;

This comment has been minimized.

Copy link
@corinagum

corinagum Aug 27, 2019

Member

Just checking, we don't want this in alphabetical order?

This comment has been minimized.

Copy link
@tonyanziano

tonyanziano Aug 27, 2019

Author Contributor

I'm not sure why it got generated that way, but it's auto-generated

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 27, 2019

Coverage Status

Coverage remained the same at 65.342% when pulling 6fdec75 on toanzian/acc-#1710 into 3dcbad5 on master.

@tonyanziano tonyanziano merged commit b58d796 into master Aug 27, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #76865 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/acc-#1710 branch Aug 27, 2019
@corinagum corinagum changed the title Fixed color contrast issues on welcome page. [#1710] Fixed color contrast issues on welcome page. Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.