Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[#1710, #1711, #1712] Fixed focus outline color issues.#1783

Merged
tonyanziano merged 1 commit into
masterfrom
toanzian/acc-#1711
Aug 27, 2019
Merged

[#1710, #1711, #1712] Fixed focus outline color issues.#1783
tonyanziano merged 1 commit into
masterfrom
toanzian/acc-#1711

Conversation

@tonyanziano
Copy link
Copy Markdown
Contributor

@tonyanziano tonyanziano commented Aug 27, 2019

#1710, #1711, #1712

===

Had to use a lighter blue for dark theme and a lighter blue for light theme because they were not passing the contrast ratio test even though it's what VS Code uses. However, the colors are both from the VS Code color palette.

Light
light_outline1

light_outline2

dark_outline3

Dark
dark_outline1

dark_outline2

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 65.518% when pulling 9f87cd0 on toanzian/acc-#1711 into 7997c47 on master.

Copy link
Copy Markdown
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyanziano tonyanziano changed the title Fixed focus outline color issues. [#1710, #1712] Fixed focus outline color issues. Aug 27, 2019
@tonyanziano tonyanziano merged commit 82dd1c6 into master Aug 27, 2019
@tonyanziano tonyanziano deleted the toanzian/acc-#1711 branch August 27, 2019 23:30
@tonyanziano tonyanziano changed the title [#1710, #1712] Fixed focus outline color issues. [#1710, #1711, #1712] Fixed focus outline color issues. Sep 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants