Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1710, #1711, #1712] Fixed focus outline color issues. #1783

Merged
merged 1 commit into from Aug 27, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Aug 27, 2019

#1710, #1711, #1712

===

Had to use a lighter blue for dark theme and a lighter blue for light theme because they were not passing the contrast ratio test even though it's what VS Code uses. However, the colors are both from the VS Code color palette.

Light
light_outline1

light_outline2

dark_outline3

Dark
dark_outline1

dark_outline2

@tonyanziano tonyanziano force-pushed the toanzian/acc-#1711 branch from 86106a3 to 9f87cd0 Aug 27, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 27, 2019

Coverage Status

Coverage remained the same at 65.518% when pulling 9f87cd0 on toanzian/acc-#1711 into 7997c47 on master.

Copy link
Member

corinagum left a comment

LGTM

@tonyanziano tonyanziano changed the title Fixed focus outline color issues. [#1710, #1712] Fixed focus outline color issues. Aug 27, 2019
@tonyanziano tonyanziano merged commit 82dd1c6 into master Aug 27, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #76922 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/acc-#1711 branch Aug 27, 2019
@tonyanziano tonyanziano changed the title [#1710, #1712] Fixed focus outline color issues. [#1710, #1711, #1712] Fixed focus outline color issues. Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.