Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1724, #1741, #1805] Fix up focus trap for dialogs #1829

Merged
merged 16 commits into from Sep 10, 2019

Conversation

@corinagum
Copy link
Member

corinagum commented Sep 4, 2019

#1724, #1741, #1805

Before undrafting this issue:

This fixes the focus trap on dialogs.

corinagum added 2 commits Sep 3, 2019
@corinagum corinagum changed the title Fix up focus trap for dialogs [#1724, #1741] Fix up focus trap for dialogs Sep 4, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 4, 2019

Coverage Status

Coverage increased (+0.01%) to 65.784% when pulling b363ca3 on corinagum/1741 into 6fe9dff on master.

corinagum added 2 commits Sep 4, 2019
@tonyanziano

This comment has been minimized.

Copy link
Contributor

tonyanziano commented Sep 6, 2019

#1805 is related as well

@corinagum corinagum changed the title [#1724, #1741] Fix up focus trap for dialogs [#1724, #1741, #1805] Fix up focus trap for dialogs Sep 6, 2019
@corinagum

This comment has been minimized.

Copy link
Member Author

corinagum commented Sep 9, 2019

working on the tests now.

corinagum added 4 commits Sep 9, 2019
@corinagum corinagum marked this pull request as ready for review Sep 9, 2019
@corinagum

This comment has been minimized.

Copy link
Member Author

corinagum commented Sep 9, 2019

This is ready for review. :)

Copy link
Contributor

tonyanziano left a comment

Looks good! Had some minor nitpicks.

packages/app/client/package.json Show resolved Hide resolved
packages/app/client/src/ui/dialogs/host/host.tsx Outdated Show resolved Hide resolved
packages/app/client/src/ui/dialogs/host/host.tsx Outdated Show resolved Hide resolved
packages/app/main/e2e/navigateADialog.spec.ts Outdated Show resolved Hide resolved
packages/app/main/e2e/navigateADialog.spec.ts Outdated Show resolved Hide resolved
corinagum added 6 commits Sep 10, 2019
…ulator into corinagum/1741
@corinagum

This comment has been minimized.

Copy link
Member Author

corinagum commented Sep 10, 2019

@tonyanziano ping, build/tests are passing. thanks for your patience

@tonyanziano tonyanziano merged commit 7c9e2bd into master Sep 10, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #78429 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the corinagum/1741 branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.