This repository was archived by the owner on Jan 5, 2026. It is now read-only.
[#1724, #1741, #1805] Fix up focus trap for dialogs#1829
Merged
Conversation
corinagum
changed the title
Contributor
|
#1805 is related as well |
corinagum
changed the title
Contributor
Author
|
working on the tests now. |
corinagum
requested review from
a-b-r-o-w-n,
compulim,
cwhitten and
tonyanziano
as code owners
Contributor
Author
|
This is ready for review. :) |
tonyanziano
suggested changes
Sep 9, 2019
Contributor
tonyanziano
left a comment
tonyanziano
left a comment
There was a problem hiding this comment.
Looks good! Had some minor nitpicks.
…ulator into corinagum/1741
Contributor
Author
|
@tonyanziano ping, build/tests are passing. thanks for your patience |
tonyanziano
approved these changes
Sep 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1724, #1741, #1805
Before undrafting this issue:
This fixes the focus trap on dialogs.