Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1792] Fixed issue with transcripts path input. #1836

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Sep 5, 2019

#1792
Fixes #1260

===

The transcripts path input field in the resource settings dialog was not editable even though it was marked as editable. This was an accessibility issue for people using screen reader technologies as well as a bug.

There was also a bug where selecting a new transcripts path by using the browse button was not resolving the promise correctly, producing [object object] within the text field.

Before:

fix_before

After:

fix_after

@tonyanziano tonyanziano force-pushed the toanzian/acc-#1792 branch from 1a3c147 to 6c4d4d4 Sep 5, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 5, 2019

Coverage Status

Coverage remained the same at 65.765% when pulling eedd596 on toanzian/acc-#1792 into f86a0d3 on master.

@tonyanziano tonyanziano force-pushed the toanzian/acc-#1792 branch from 6c4d4d4 to cd8c12e Sep 5, 2019
Copy link
Member

corinagum left a comment

LGTM

@tonyanziano tonyanziano force-pushed the toanzian/acc-#1792 branch from cd8c12e to eedd596 Sep 6, 2019
@tonyanziano tonyanziano merged commit c87a412 into master Sep 6, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #78017 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/acc-#1792 branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.