Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

#1744 Fix Restart conversation menu#1844

Merged
tonyanziano merged 8 commits into
masterfrom
corinagum/1744
Sep 6, 2019
Merged

#1744 Fix Restart conversation menu#1844
tonyanziano merged 8 commits into
masterfrom
corinagum/1744

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

@corinagum corinagum commented Sep 5, 2019

#1750

This PR tweaks the "Restart conversation" menu items in the chat view.

Please note: this component has been updated from 'listbox' role to 'menu' role.

Semantically, the behavior we want to emulate more closely matches the menu bar. For an accessible example, please see w3.org menubar2

This fix returns focus to the caret (next to Restart conversation button) after an action has been selected from the submenu.

Below is the transcribed behavior when navigating the toolbar that contains Restart Conversation.

  • Focus jumps to "Restart conversation" button
    • NVDA says: "Restart conversation 1 of 3"
  • Tab : NVDA says: "Restart conversation submenu 2 of 3"
  • Tab : NVDA says: "Save transcript"

When focused on "Restart conversation menu":
Enter : NVDA says: "Restart with new user ID 1 of 2"
: NVDA says "Restart with same user ID 2 of 2"
Enter : NVDA says "Restart conversation submenu 2 of 3"

Below is an animated gif of the behavior using keyboard navigation.

ezgif-4-da0ca77dcfcd

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 5, 2019

Coverage Status

Coverage increased (+0.002%) to 65.77% when pulling f1f8d23 on corinagum/1744 into 57bf5b6 on master.

Comment thread packages/sdk/ui-react/src/widget/splitButton/splitButton.tsx Outdated
@compulim
Copy link
Copy Markdown
Contributor

compulim commented Sep 6, 2019

We go back-and-forth, then back-and-forth again. Almost rewrote it. But we finally figured out it should be role="menu" than role="listbox". 🤣

So many work and think process, so little showing in this PR.

tonyanziano
tonyanziano previously approved these changes Sep 6, 2019
Copy link
Copy Markdown
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

Fix the changelog conflict and I'll merge it in once CI passes.

Copy link
Copy Markdown
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tonyanziano tonyanziano merged commit e434a70 into master Sep 6, 2019
@tonyanziano tonyanziano deleted the corinagum/1744 branch September 6, 2019 22:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants