Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1744 Fix Restart conversation menu #1844

Merged
merged 8 commits into from Sep 6, 2019

Conversation

@corinagum
Copy link
Member

corinagum commented Sep 5, 2019

#1750

This PR tweaks the "Restart conversation" menu items in the chat view.

Please note: this component has been updated from 'listbox' role to 'menu' role.

Semantically, the behavior we want to emulate more closely matches the menu bar. For an accessible example, please see w3.org menubar2

This fix returns focus to the caret (next to Restart conversation button) after an action has been selected from the submenu.

Below is the transcribed behavior when navigating the toolbar that contains Restart Conversation.

  • Focus jumps to "Restart conversation" button
    • NVDA says: "Restart conversation 1 of 3"
  • Tab : NVDA says: "Restart conversation submenu 2 of 3"
  • Tab : NVDA says: "Save transcript"

When focused on "Restart conversation menu":
Enter : NVDA says: "Restart with new user ID 1 of 2"
: NVDA says "Restart with same user ID 2 of 2"
Enter : NVDA says "Restart conversation submenu 2 of 3"

Below is an animated gif of the behavior using keyboard navigation.

ezgif-4-da0ca77dcfcd

corinagum added 2 commits Sep 5, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 5, 2019

Coverage Status

Coverage increased (+0.002%) to 65.77% when pulling f1f8d23 on corinagum/1744 into 57bf5b6 on master.

corinagum added 2 commits Sep 6, 2019
@compulim

This comment has been minimized.

Copy link
Contributor

compulim commented Sep 6, 2019

We go back-and-forth, then back-and-forth again. Almost rewrote it. But we finally figured out it should be role="menu" than role="listbox". 🤣

So many work and think process, so little showing in this PR.

Copy link
Contributor

tonyanziano left a comment

Good work!

Fix the changelog conflict and I'll merge it in once CI passes.

corinagum added 2 commits Sep 6, 2019
Copy link
Contributor

tonyanziano left a comment

👍

@tonyanziano tonyanziano merged commit e434a70 into master Sep 6, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #78141 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the corinagum/1744 branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.