Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1753 fix focus indicator on file upload button #1855

Merged
merged 3 commits into from Sep 10, 2019

Conversation

@corinagum
Copy link
Member

corinagum commented Sep 10, 2019

image

#1753

Previously the focus indicator on the File Upload button in chat was not showing up. This fix now shows the focus, as seen above.

@@ -31,7 +31,9 @@
"prettier": "^1.15.3"
},
"jest": {
"setupFilesAfterEnv": ["./testSetup.js"],
"setupFilesAfterEnv": [

This comment has been minimized.

Copy link
@corinagum

corinagum Sep 10, 2019

Author Member

Just FYI, this change was by the linter, not me.

Copy link
Contributor

tonyanziano left a comment

Nice!

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 10, 2019

Coverage Status

Coverage increased (+0.005%) to 65.775% when pulling 33b400c on corinagum/1753 into e434a70 on master.

@corinagum

This comment has been minimized.

Copy link
Member Author

corinagum commented Sep 10, 2019

@tonyanziano test fixed, sorry about that

Copy link
Contributor

tonyanziano left a comment

Awesome

@tonyanziano tonyanziano merged commit 7bccc93 into master Sep 10, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #78407 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the corinagum/1753 branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.