#1811 Fix overflowing dialogs so they are scrollable

[corinagum]

#1811

This fix adds a maximum height to dialogs so that zooming in or overflow will make the dialog scrollable, instead of creating unreachable parts of the modal.

Before scrolling down:

After scrolling down:

@DesignPolice - just checking in that not having a visible scrollbar on the outside of the dialog is still the desirable appearance.

[coveralls]

Coverage remained the same at 65.787% when pulling 5e02a7e on corinagum/1811 into f034cbc on master.

[tonyanziano]

Just waiting on a response from @DesignPolice regarding the invisible scrollbar, and then we can merge this in.

[DesignPolice]

Thanks for fixing this @tonyanziano @corinagum - I think we will be updating all of the visuals with Emulator soon, so if this treatment will pass for a few months lets see how it tests - and not spend time doing something we are going to redo. IF it still is an issue I will build a new box with a scroll and smaller X

thanks

===

Edited because @corinagum actually fixed this one 😅 -Tony

[tonyanziano]

👍