Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1811 Fix overflowing dialogs so they are scrollable #1859

Merged
merged 7 commits into from Sep 11, 2019

Conversation

@corinagum
Copy link
Member

corinagum commented Sep 10, 2019

#1811

This fix adds a maximum height to dialogs so that zooming in or overflow will make the dialog scrollable, instead of creating unreachable parts of the modal.

Before scrolling down:
image
After scrolling down:

image

@DesignPolice - just checking in that not having a visible scrollbar on the outside of the dialog is still the desirable appearance.

corinagum added 2 commits Sep 10, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 10, 2019

Coverage Status

Coverage remained the same at 65.787% when pulling 5e02a7e on corinagum/1811 into f034cbc on master.

corinagum added 4 commits Sep 10, 2019
@tonyanziano

This comment has been minimized.

Copy link
Contributor

tonyanziano commented Sep 11, 2019

Just waiting on a response from @DesignPolice regarding the invisible scrollbar, and then we can merge this in.

@DesignPolice

This comment has been minimized.

Copy link
Member

DesignPolice commented Sep 11, 2019

Thanks for fixing this @tonyanziano @corinagum - I think we will be updating all of the visuals with Emulator soon, so if this treatment will pass for a few months lets see how it tests - and not spend time doing something we are going to redo. IF it still is an issue I will build a new box with a scroll and smaller X

thanks

===

Edited because @corinagum actually fixed this one 😅 -Tony

Copy link
Contributor

tonyanziano left a comment

👍

@tonyanziano tonyanziano merged commit c7a8a91 into master Sep 11, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #78546 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the corinagum/1811 branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.