Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#1818][MAS4.1.2] [Screen Reader-Debug] Screen reader is not reading the state for Expanded or collapsed control #1863

Merged
merged 6 commits into from Sep 13, 2019

Conversation

@denscollo
Copy link
Collaborator

denscollo commented Sep 11, 2019

Solves #1818

Description

With this PR we enabled the screen reader to identify when the elements of the JSON viewer extension are expanded and collapsed.

Changes made

  • Screen reader reads collapse/expand

Since the screen reader wasn't reading the aria-expanded property from the ul tags, we added that property to the parent li

denscollo added 2 commits Sep 11, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 11, 2019

Coverage Status

Coverage increased (+0.02%) to 65.762% when pulling 6584b76 on fix/screen-reader-reads-collapse into 2743410 on master.

Copy link
Contributor

tonyanziano left a comment

I pulled the branch down and tested it and found an issue:

The aria-expanded attribute isn't being added to the <li> tags when they are initialized for the first time, it is only being added on a click event. This means that the screen reader won't read the expanded / collapsed states until after they are expanded or collapsed for the first time via mouse / keyboard.

Before clicking:

image

image

After clicking:

image

image

The tree needs to be accessible when it is rendered for the first time.

@denscollo

This comment has been minimized.

Copy link
Collaborator Author

denscollo commented Sep 13, 2019

Thanks @tonyanziano for the feedback. We'll test it again and fix it!

denscollo added 2 commits Sep 13, 2019
@denscollo

This comment has been minimized.

Copy link
Collaborator Author

denscollo commented Sep 13, 2019

@tonyanziano we finished applying the changes. Now it's ready for review! Thanks!

Copy link
Contributor

tonyanziano left a comment

Looks good!

@tonyanziano tonyanziano merged commit 1bd4014 into master Sep 13, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #78872 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the fix/screen-reader-reads-collapse branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.