Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1793] Fixed focus order a11y issue with resources dialog. #1883

Merged
merged 1 commit into from Sep 26, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Sep 26, 2019

#1793

===

Fixes focus order of Dialog controls while in browse mode so that it is aligned with how the dialog is laid out visually.

Previous order:

Dialog heading -> Close button -> Dialog content

New order:

Close button -> Dialog heading -> Dialog content

@tonyanziano tonyanziano force-pushed the toanzian/acc-#1793 branch from a7deeb7 to e7847ba Sep 26, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 26, 2019

Coverage Status

Coverage remained the same at 65.913% when pulling e7847ba on toanzian/acc-#1793 into e73b856 on master.

Copy link
Member

corinagum left a comment

LGTM

@tonyanziano tonyanziano merged commit 2eaf596 into master Sep 26, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #80685 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/acc-#1793 branch Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.