Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[#1730] Fixed open bot dialog url validation a11y issue.#1918

Merged
tonyanziano merged 1 commit into
masterfrom
toanzian/acc-#1846
Oct 8, 2019
Merged

[#1730] Fixed open bot dialog url validation a11y issue.#1918
tonyanziano merged 1 commit into
masterfrom
toanzian/acc-#1846

Conversation

@tonyanziano
Copy link
Copy Markdown
Contributor

@tonyanziano tonyanziano commented Oct 8, 2019

#1846 #1730

===

  • Removed ARIA alerts for Bot URL validation
  • Added functionality to <AutoComplete /> component so that it properly narrates any error messages

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.01%) to 65.917% when pulling c8a8884 on toanzian/acc-#1846 into c53ac1d on master.

Copy link
Copy Markdown
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tonyanziano tonyanziano merged commit 98e7b21 into master Oct 8, 2019
@tonyanziano tonyanziano deleted the toanzian/acc-#1846 branch October 8, 2019 17:18
@tonyanziano tonyanziano changed the title [#1846] Fixed open bot dialog url validation a11y issue. [#1730] Fixed open bot dialog url validation a11y issue. Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants