Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1730] Fixed open bot dialog url validation a11y issue. #1918

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Oct 8, 2019

#1846 #1730

===

  • Removed ARIA alerts for Bot URL validation
  • Added functionality to <AutoComplete /> component so that it properly narrates any error messages
@tonyanziano tonyanziano force-pushed the toanzian/acc-#1846 branch from 2ab9a30 to c8a8884 Oct 8, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 8, 2019

Coverage Status

Coverage decreased (-0.01%) to 65.917% when pulling c8a8884 on toanzian/acc-#1846 into c53ac1d on master.

Copy link
Member

corinagum left a comment

LGTM!

@tonyanziano tonyanziano merged commit 98e7b21 into master Oct 8, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #82030 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/acc-#1846 branch Oct 8, 2019
@tonyanziano tonyanziano changed the title [#1846] Fixed open bot dialog url validation a11y issue. [#1730] Fixed open bot dialog url validation a11y issue. Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.