Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

#1806 Fix AT readout of botCreationDialog secret buttons#1921

Merged
corinagum merged 3 commits into
masterfrom
corinagum/1806
Oct 9, 2019
Merged

#1806 Fix AT readout of botCreationDialog secret buttons#1921
corinagum merged 3 commits into
masterfrom
corinagum/1806

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

@corinagum corinagum commented Oct 9, 2019

#1806

image

Various minor fixes

  • Adds an aria-label "Bot encryption key" to the secret's textfield
  • Changes placeholder text (which is read by the AT) to read "Your keys are not encrypted", encryptKeys boolean is true
  • adds aria-label to the <TextField> component.
  • Styling fixes for the Hide Secret and Copy Secret buttons, which also fixes the way the AT reads both buttons out in browse mode

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 9, 2019

Coverage Status

Coverage increased (+0.005%) to 66.897% when pulling 3b48994 on corinagum/1806 into 2a14fe6 on master.

Copy link
Copy Markdown
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Also thanks for the styling fix, that was driving me crazy but never got around to it 😅

Had one suggestion.

Comment thread packages/app/client/src/ui/dialogs/botCreationDialog/botCreationDialog.tsx Outdated
Copy link
Copy Markdown
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge once CI goes green 👍

@corinagum corinagum merged commit 4ec726f into master Oct 9, 2019
@tonyanziano tonyanziano deleted the corinagum/1806 branch October 22, 2019 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants