Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1806 Fix AT readout of botCreationDialog secret buttons #1921

Merged
merged 3 commits into from Oct 9, 2019

Conversation

@corinagum
Copy link
Member

corinagum commented Oct 9, 2019

#1806

image

Various minor fixes

  • Adds an aria-label "Bot encryption key" to the secret's textfield
  • Changes placeholder text (which is read by the AT) to read "Your keys are not encrypted", encryptKeys boolean is true
  • adds aria-label to the <TextField> component.
  • Styling fixes for the Hide Secret and Copy Secret buttons, which also fixes the way the AT reads both buttons out in browse mode
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 9, 2019

Coverage Status

Coverage increased (+0.005%) to 66.897% when pulling 3b48994 on corinagum/1806 into 2a14fe6 on master.

Copy link
Contributor

tonyanziano left a comment

Nice job. Also thanks for the styling fix, that was driving me crazy but never got around to it 😅

Had one suggestion.

Copy link
Contributor

tonyanziano left a comment

Good to merge once CI goes green 👍

@corinagum corinagum merged commit 4ec726f into master Oct 9, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #82541 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the corinagum/1806 branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.