Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#1834][MAS4.2.1] [Screen reader -Debug] In forward navigation NVDA is not reading the under JSON tab section controls information #1923

Merged

Conversation

@denscollo
Copy link
Collaborator

denscollo commented Oct 10, 2019

Solves #1834

Description

This pull request enables the NVDA to read the content of the JSON web viewer.

Changes made

  • Remove tab index from panel content to allow the Screen Reader to read the content of the JSON tree view.
    a
    The panel content had an attribute tabindex which causes conflicts with the screen reader navigation using the tab control.
    image

Test

We navigate through the component using the tab control and the NVDA read the information of the elements as we expected.
image

…n-reader
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 10, 2019

Coverage Status

Coverage decreased (-0.04%) to 66.897% when pulling 00172c5 on fix/json-web-view-forward-navigation-screen-reader into a66f568 on master.

Copy link
Contributor

tonyanziano left a comment

Tested and it looks good!

@tonyanziano tonyanziano merged commit e174390 into master Oct 10, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #82682 succeeded
Details
license/cla All CLA requirements met.
@tonyanziano tonyanziano deleted the fix/json-web-view-forward-navigation-screen-reader branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.