Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unnecessary Web Chat re-renders caused by interaction with activities #1930

Merged
merged 1 commit into from Oct 22, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Oct 16, 2019

Fixes #1701

===

Web Chat was being completely re-rendered, which was causing Adaptive Card state to be wiped. The following interactions with Web Chat would cause this:

  1. Sending messages in the chat
  2. Clicking on activities and selecting / highlighting them

The fix prevents these re-renders by fixing the way app state was being plumbed through the components.

The entire document object is no longer plumbed down through the emulator.tsx component and its children. Instead, documentId is plumbed through these components, and then each component uses this id to fetch whatever relevant information from the store that it needs.


Also added electron-devtools-installer which resolves #1650 , and adds React Dev Tools as well as Redux Dev Tools.

===

Still need to add / fix tests.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 18, 2019

Coverage Status

Coverage increased (+0.05%) to 66.949% when pulling 945d084 on toanzian/adaptive-fix into 5f34abf on master.

@tonyanziano tonyanziano force-pushed the toanzian/adaptive-fix branch from 2a3cc9a to b6e4613 Oct 18, 2019
@tonyanziano tonyanziano marked this pull request as ready for review Oct 18, 2019
Copy link
Member

corinagum left a comment

LGTM

@tonyanziano

This comment has been minimized.

Copy link
Contributor Author

tonyanziano commented Oct 21, 2019

Don't merge this yet, I think there might be a bug with the activity middleware.

Should be all good now

@tonyanziano tonyanziano force-pushed the toanzian/adaptive-fix branch from b6e4613 to 945d084 Oct 21, 2019
@tonyanziano tonyanziano merged commit 2717295 into master Oct 22, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #84670 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/adaptive-fix branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.