Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[ISSUE#1900][MAS4.2.1][Screen reader-How to Build a Bot] In voiceover mode, the contents are announced as “1 of 2 plan “ and "2 of 2 review the bot"#1933

Merged
tonyanziano merged 4 commits into
masterfrom
fix/how-to-build-a-bot-voice-over-content
Oct 18, 2019
Merged

[ISSUE#1900][MAS4.2.1][Screen reader-How to Build a Bot] In voiceover mode, the contents are announced as “1 of 2 plan “ and "2 of 2 review the bot"#1933
tonyanziano merged 4 commits into
masterfrom
fix/how-to-build-a-bot-voice-over-content

Conversation

@denscollo
Copy link
Copy Markdown
Contributor

Solves #1900

Description

This pull request fixes the styles of the elements of the "How to build a bot" section to allows voice over to read the content properly

Changes made

The use of definition lists can cause conflicts when using screen readers as it doesn’t differentiate a definition list from other lists, listing the amount of elements it contains as we can see in the issue, "1 of 2 plan", for example.
We changed the definition list tags for paragraph tags, now the voiceover reads the elements properly.

To fix the duplicated read of the first element of each section we changed the ::before in the CSS style to an ::after

Test

After update the component works as we expected.
HowToBuildABotIssue

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 66.897% when pulling 7ee586d on fix/how-to-build-a-bot-voice-over-content into d5a714a on master.

Copy link
Copy Markdown
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@tonyanziano tonyanziano merged commit 5f34abf into master Oct 18, 2019
@tonyanziano tonyanziano deleted the fix/how-to-build-a-bot-voice-over-content branch October 18, 2019 16:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants