Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#1900][MAS4.2.1][Screen reader-How to Build a Bot] In voiceover mode, the contents are announced as “1 of 2 plan “ and "2 of 2 review the bot" #1933

Merged
merged 4 commits into from Oct 18, 2019

Conversation

@denscollo
Copy link
Collaborator

denscollo commented Oct 17, 2019

Solves #1900

Description

This pull request fixes the styles of the elements of the "How to build a bot" section to allows voice over to read the content properly

Changes made

The use of definition lists can cause conflicts when using screen readers as it doesn’t differentiate a definition list from other lists, listing the amount of elements it contains as we can see in the issue, "1 of 2 plan", for example.
We changed the definition list tags for paragraph tags, now the voiceover reads the elements properly.

To fix the duplicated read of the first element of each section we changed the ::before in the CSS style to an ::after

Test

After update the component works as we expected.
HowToBuildABotIssue

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 17, 2019

Coverage Status

Coverage remained the same at 66.897% when pulling 7ee586d on fix/how-to-build-a-bot-voice-over-content into d5a714a on master.

Copy link
Contributor

tonyanziano left a comment

Looks good, thanks.

@tonyanziano tonyanziano merged commit 5f34abf into master Oct 18, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #84076 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the fix/how-to-build-a-bot-voice-over-content branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.