This repository was archived by the owner on Jan 5, 2026. It is now read-only.
[ISSUE#1899][MAS2.4.6] [Headings and Labels - Open Bot Dialog] Heading should be defined for the pop-up or dialog#1936
Merged
Conversation
Added h1 tag to the title in the dialogs and added a new style for this headers
denscollo
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten and
tonyanziano
as code owners
Contributor
|
The build failed due to a network issue or something, I kicked off another one." |
tonyanziano
reviewed
Oct 23, 2019
Contributor
tonyanziano
left a comment
tonyanziano
left a comment
There was a problem hiding this comment.
Looks good. CI wasn't working yesterday for this PR, but I think the network issue has been cleared up. Build running now is looking good.
I'll approve and merge in once comment is addressed and CI build succeeds.
tonyanziano
approved these changes
Oct 23, 2019
Contributor
tonyanziano
left a comment
tonyanziano
left a comment
There was a problem hiding this comment.
I went ahead and added the newline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #1899
Description
Fixes how voiceover announces the heading for the pop-up or dialogs, by updating this component all the dialog titles will be announced.
Changes made
We updated the dialog component to use an
<h1>HTML tag for heading.Test
Now, the voiceover is reading the title of the dialog before announcing the content.