Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#1899][MAS2.4.6] [Headings and Labels - Open Bot Dialog] Heading should be defined for the pop-up or dialog #1936

Merged
merged 5 commits into from Oct 23, 2019

Conversation

@denscollo
Copy link
Collaborator

denscollo commented Oct 22, 2019

Solves #1899

Description

Fixes how voiceover announces the heading for the pop-up or dialogs, by updating this component all the dialog titles will be announced.

Changes made

We updated the dialog component to use an <h1> HTML tag for heading.

Test

Now, the voiceover is reading the title of the dialog before announcing the content.

image
image
image

santgr11 and others added 2 commits Oct 18, 2019
Added h1 tag to the title in the dialogs and added a new style for this headers
denscollo added 2 commits Oct 22, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 22, 2019

Coverage Status

Coverage remained the same at 66.949% when pulling 35dda87 on fix/define-header-in-dialogs into ffa96e8 on master.

@tonyanziano

This comment has been minimized.

Copy link
Contributor

tonyanziano commented Oct 22, 2019

The build failed due to a network issue or something, I kicked off another one."

Copy link
Contributor

tonyanziano left a comment

Looks good. CI wasn't working yesterday for this PR, but I think the network issue has been cleared up. Build running now is looking good.

I'll approve and merge in once comment is addressed and CI build succeeds.

packages/sdk/ui-react/src/widget/dialog/dialog.scss Outdated Show resolved Hide resolved
Copy link
Contributor

tonyanziano left a comment

I went ahead and added the newline

@tonyanziano tonyanziano merged commit 566a579 into master Oct 23, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #85298 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the fix/define-header-in-dialogs branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.