Skip to content

Layout starter prompt card action without image#5263

Merged
compulim merged 7 commits intomainfrom
fix-starter-prompts-without-image
Aug 20, 2024
Merged

Layout starter prompt card action without image#5263
compulim merged 7 commits intomainfrom
fix-starter-prompts-without-image

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Aug 20, 2024

Changelog Entry

Fixed

  • (Experimental) Added pre-chat message with starter prompts in Fluent UI, in PR #5255 and #5263, by @compulim

Description

Fixes starter prompts without image should not leave a gutter for the image.

Design

Specific Changes

  • Updated starter prompts card action with new CSS class to remove the image gutter
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review August 20, 2024 00:45
Comment thread packages/fluent-theme/src/components/preChatActivity/StarterPromptsCardAction.tsx Outdated
@OEvgeny
Copy link
Copy Markdown
Collaborator

OEvgeny commented Aug 20, 2024

Looks good, I think we should rely on actual DOM structure for applying CSS styles though: this makes us to not duplicate conditions and also makes markup structure a source of truth for our styles, which is extremely good for cases where grid is involved at least.

OEvgeny
OEvgeny previously approved these changes Aug 20, 2024
@compulim compulim enabled auto-merge (squash) August 20, 2024 01:33
@compulim compulim merged commit 2dbeed3 into main Aug 20, 2024
@compulim compulim deleted the fix-starter-prompts-without-image branch August 20, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants