Layout starter prompt card action without image#5263
Merged
Conversation
OEvgeny
reviewed
Aug 20, 2024
OEvgeny
reviewed
Aug 20, 2024
OEvgeny
reviewed
Aug 20, 2024
Collaborator
|
Looks good, I think we should rely on actual DOM structure for applying CSS styles though: this makes us to not duplicate conditions and also makes markup structure a source of truth for our styles, which is extremely good for cases where grid is involved at least. |
OEvgeny
reviewed
Aug 20, 2024
OEvgeny
reviewed
Aug 20, 2024
OEvgeny
previously approved these changes
Aug 20, 2024
OEvgeny
approved these changes
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
Fixes starter prompts without image should not leave a gutter for the image.
Design
Specific Changes
CHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)z-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)