Fluent: allow message bubble to grow past 450px up to 75%#5324
Merged
Conversation
compulim
approved these changes
Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
This PR enhances the message bubble layout in the Fluent theme for Web Chat. It allows message bubbles to grow beyond the previous fixed maximum width of 450px, up to 75% of their container width as well as passing
--bubble-minWidthfrom the outside. As the theme design suggests it affects only bot message.Design
The idea is simple to allow further grow past 450px only if container has the width available. By adjusting
min-widthfrom the outside developers can limit the minimum message width.Specific Changes
ActivityDecorator.module.css:--webchat-bubble-maxWidthto usemin(max(450px, 75%), 100%).--webchat-bubble-minWidthvariable.-
CHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)