Add code block copy button#5334
Merged
compulim merged 37 commits intomicrosoft:mainfrom Oct 26, 2024
Merged
Conversation
OEvgeny
previously approved these changes
Oct 25, 2024
OEvgeny
reviewed
Oct 25, 2024
OEvgeny
previously approved these changes
Oct 25, 2024
OEvgeny
previously approved these changes
Oct 25, 2024
OEvgeny
reviewed
Oct 26, 2024
OEvgeny
reviewed
Oct 26, 2024
OEvgeny
previously approved these changes
Oct 26, 2024
OEvgeny
reviewed
Oct 26, 2024
OEvgeny
previously approved these changes
Oct 26, 2024
OEvgeny
approved these changes
Oct 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
Description
For code blocks inside Markdown (via triple-backtick or
<pre>), we will add a copy button on the top right corner of it.Design
We are introducing internal-use Web Components.
As we go through sanitization, DOM become string and it lose event handler. In other words, we cannot listen to "click" event on the button after sanitization.
Our solution is to use Web Components so we can preserve logic during sanitization.
Alternatively, we could have a catch-all click handler on Markdown, but it is not trivial as Adaptive Cards requires a HTML string instead of DOM too. That means, we will need to put a catch-all container in 2+ different places.
Specific Changes
CustomElementsProviderto host internal-use hash-secured Web Components<webchat-xxxxx--code-block-copy-button>wherexxxxxis a random hashpackage.jsonviatouchso changes tocorewill trigger rebuild ofapi, and so onCHANGELOG.mdI have updated documentationReview Checklist
Browser and platform compatibilities reviewedz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewed