fix: math parsing hangs webchat#5377
Merged
Merged
Conversation
compulim
reviewed
Nov 13, 2024
compulim
reviewed
Nov 13, 2024
Co-authored-by: William Wong <compulim@users.noreply.github.com>
Co-authored-by: William Wong <compulim@users.noreply.github.com>
compulim
approved these changes
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
This PR addresses a critical issue where Web Chat could hang when parsing certain LaTeX mathematical expressions. The problem occurred specifically when processing escaped sequences in math blocks, particularly affecting expressions with trailing backslashes or incomplete delimiters.
Design
We don't process escape sequences, unless it's an end delimiter. Otherwise we hand processing over to the content state processor which will properly handle line breaks and such.
Specific Changes
escapedfunction tomaybeCloseDelimeterfor better clarity of intent-
CHANGELOG.mdI have updated documentationReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed