Copy button to use outerHTML/textContent#5378
Merged
Merged
Conversation
compulim
requested review from
a-b-r-o-w-n,
beyackle2,
cwhitten,
srinaath and
tdurnford
as code owners
compulim
changed the title
outerHTML/textContent
OEvgeny
reviewed
Nov 14, 2024
Comment on lines
+3
to
+8
| <head> | ||
| <script> | ||
| location = './layout?theme=dark&variant=copilot'; | ||
| </script> | ||
| </head> | ||
| <body></body> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <head> | |
| <script> | |
| location = './layout?theme=dark&variant=copilot'; | |
| </script> | |
| </head> | |
| <body></body> | |
| <meta http-equiv="refresh" content="0;URL=./layout?theme=dark&variant=copilot"> |
OEvgeny
approved these changes
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Changed
outerHTMLandtextContentfor clipboard content, in PR #5378, by @compulimDescription
Instead of rendering Markdown again for clipboard, this PR is copying HTML contents directly from DOM element to clipboard. This solves a few problems:
Design
Use
textContentfortext/plain. UseouterHTMLfortext/html.We tried
text/markdownbut the write operation was blocked by browser.As we no longer use Markdown engine for the copy button, we removed the
"clipboard"option inuseRenderMarkdownAsHTML()hook.Specific Changes
<ActivityCopyButton>withtargetRef, instead ofmarkdownTextandplainTexttextContentandouterHTMLfor contents to write to clipboardhtmltohtml2location = './layout?...';for permutation"clipboard"option inuseRenderMarkdownAsHTML"accessible name"option when used in live regionCHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)