Move internal packages to @msinternal/*#5531
Merged
Conversation
compulim
requested review from
a-b-r-o-w-n,
beyackle2,
cwhitten,
srinaath and
tdurnford
as code owners
OEvgeny
previously approved these changes
Aug 3, 2025
Collaborator
|
Add |
OEvgeny
approved these changes
Aug 3, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves internal/non-publishing packages to the @msinternal/* namespace by renaming package names and updating imports throughout the codebase. This provides better organization and clarity by distinguishing internal development packages from publicly published packages.
- Renamed all internal package names from their original names to
@msinternal/*scoped packages - Updated all import statements and dependencies to reference the new scoped package names
- Added
.npmrcwithignore-scripts=trueconfiguration to prevent script execution during installs
Reviewed Changes
Copilot reviewed 129 out of 132 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
packages/*/package.json |
Updated package names to @msinternal/* and dependency references |
packages/*/src/**/*.{ts,tsx,js,mjs} |
Updated import statements to use new scoped package names |
packages/*/tsconfig.json |
Updated TypeScript configuration references |
.github/workflows/*.yml |
Added --ignore-scripts flag to npm install commands |
.npmrc |
Added ignore-scripts configuration |
packages/component/src/ActivityFeedback/providers/ActivityFeedbackComposer.tsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
Move internal/non-publishing packages to
@msinternal/*.Design
Specific Changes
@msinternal/*I have updatedCHANGELOG.mdReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)