Add PR validation workflow#26
Merged
Merged
Conversation
Add GitHub Actions checks for CLI install, build, tests, and smoke validation. Scope event cache loading so event-specific CLI smoke tests do not fetch unrelated catalogs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds PR/push CI validation for the cli/ package (build, unit tests, and smoke tests), and updates cache loading so --event scoped commands only load/fetch the requested event’s cache.
Changes:
- Add a GitHub Actions CI workflow to run
npm ci, build, unit tests, and a fixture-backed CLI smoke test on PRs; additionally run a live-catalog smoke test on non-PR runs. - Introduce fixture and live smoke test scripts and wire them into
cli/package.jsonscripts. - Scope
ensureCache()to an optional event filter and add/extend tests verifying scoped cache behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
cli/test/cache.test.ts |
Adds tests ensuring scoped cache loading doesn’t touch unrelated events and handles failures without fallback. |
cli/src/commands/sessions.ts |
Validates --event and scopes cache loading to the requested event. |
cli/src/commands/session.ts |
Validates --event and scopes cache loading to the requested event. |
cli/src/commands/common.ts |
Updates ensureCache() to accept an optional event filter and adjusts fallback behavior accordingly. |
cli/scripts/smoke-live.mjs |
Adds a live catalog smoke test that refreshes cache and verifies status/sessions/session output. |
cli/scripts/smoke-fixture.mjs |
Adds a deterministic fixture-backed smoke test that seeds cache files and validates CLI behavior. |
cli/package.json |
Adds smoke:fixture and smoke:live npm scripts. |
.github/workflows/ci.yml |
Adds CI workflow to run build/test and smoke tests (fixture on PRs; live on non-PR runs). |
Convert smoke script working directories to filesystem paths and add timeout/retry handling for live catalog refreshes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
pdebruin
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation