Skip to content

Add PR validation workflow#26

Merged
pdebruin merged 2 commits into
mainfrom
ci/pr-validation-smoke-tests
May 13, 2026
Merged

Add PR validation workflow#26
pdebruin merged 2 commits into
mainfrom
ci/pr-validation-smoke-tests

Conversation

@TianqiZhang
Copy link
Copy Markdown
Contributor

Summary

  • Add a CI workflow for PR validation of the CLI package
  • Run npm install, build, unit tests, and a deterministic fixture-backed CLI smoke test on PRs
  • Add a live catalog smoke test for pushes to main and manual workflow runs
  • Scope event cache loading so --event checks only fetch/manage the requested event

Validation

  • npm run build
  • npm test
  • npm run smoke:fixture
  • npm run smoke:live

Add GitHub Actions checks for CLI install, build, tests, and smoke validation. Scope event cache loading so event-specific CLI smoke tests do not fetch unrelated catalogs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds PR/push CI validation for the cli/ package (build, unit tests, and smoke tests), and updates cache loading so --event scoped commands only load/fetch the requested event’s cache.

Changes:

  • Add a GitHub Actions CI workflow to run npm ci, build, unit tests, and a fixture-backed CLI smoke test on PRs; additionally run a live-catalog smoke test on non-PR runs.
  • Introduce fixture and live smoke test scripts and wire them into cli/package.json scripts.
  • Scope ensureCache() to an optional event filter and add/extend tests verifying scoped cache behavior.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
cli/test/cache.test.ts Adds tests ensuring scoped cache loading doesn’t touch unrelated events and handles failures without fallback.
cli/src/commands/sessions.ts Validates --event and scopes cache loading to the requested event.
cli/src/commands/session.ts Validates --event and scopes cache loading to the requested event.
cli/src/commands/common.ts Updates ensureCache() to accept an optional event filter and adjusts fallback behavior accordingly.
cli/scripts/smoke-live.mjs Adds a live catalog smoke test that refreshes cache and verifies status/sessions/session output.
cli/scripts/smoke-fixture.mjs Adds a deterministic fixture-backed smoke test that seeds cache files and validates CLI behavior.
cli/package.json Adds smoke:fixture and smoke:live npm scripts.
.github/workflows/ci.yml Adds CI workflow to run build/test and smoke tests (fixture on PRs; live on non-PR runs).

Comment thread cli/scripts/smoke-fixture.mjs
Comment thread cli/scripts/smoke-live.mjs
Comment thread .github/workflows/ci.yml
Convert smoke script working directories to filesystem paths and add timeout/retry handling for live catalog refreshes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pdebruin
Copy link
Copy Markdown
Collaborator

#21

@pdebruin pdebruin merged commit 43c14f5 into main May 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants