Failed to load ActiveDirectory module fix#1013
Merged
Merged
Conversation
We can't remove the PSDrive if we fail to load the module or never created the New-PSDrive. Set a variable to true after creating the drive, then in finally block only remove it if it is set to true.
bill-long
approved these changes
May 10, 2022
lusassl-msft
approved these changes
May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Failed to load Active Directory module, then proceed to try to remove the PSDrive, even though we never created one.
Fix:
Set a variable to true after running
New-PSDrive, then in finally block only runRemove-PSDriveif variable is set to true.Validation:
Customer confirmed fix.
Resolved #1012