Skip to content

SimplePerf: Use COMPUTERNAME instead of localhost#1076

Merged
bill-long merged 1 commit into
mainfrom
bilong-simpleperf
May 23, 2022
Merged

SimplePerf: Use COMPUTERNAME instead of localhost#1076
bill-long merged 1 commit into
mainfrom
bilong-simpleperf

Conversation

@bill-long
Copy link
Copy Markdown
Member

Fixes #1075

Counter paths now reflect the computer name rather than localhost:

[PS] C:\code\CSS-Exchange\dist>Get-ExchangeServer | .\SimplePerf.ps1 -Start -Scenario None -IncludeCounters "\Network Interface(*)" -Verbose
LAB1E15: Removing existing SimplePerf collector.
LAB1E15: Getting list of counters.
LAB1E15: Applying filters.
LAB1E15: The following counters matched the specified filters:
LAB1E15: \\LAB1E15\Network Interface(*)\*
LAB1E15: Creating SimplePerf collector, writing to C:\SimplePerf\220523081812.
The command completed successfully.
LAB1E15: Starting SimplePerf collector.
The command completed successfully.
LAB1E16: Removing existing SimplePerf collector.
LAB1E16: Getting list of counters.
LAB1E16: Applying filters.
LAB1E16: The following counters matched the specified filters:
LAB1E16: \\LAB1E16\Network Interface(*)\*
LAB1E16: Creating SimplePerf collector, writing to C:\SimplePerf\220523121821.
The command completed successfully.
LAB1E16: Starting SimplePerf collector.
The command completed successfully.
LAB1E19-1: Removing existing SimplePerf collector.
LAB1E19-1: Getting list of counters.
LAB1E19-1: Applying filters.
LAB1E19-1: The following counters matched the specified filters:
LAB1E19-1: \\LAB1E19-1\Network Interface\*
LAB1E19-1: Creating SimplePerf collector, writing to C:\SimplePerf\220523081831.
The command completed successfully.
LAB1E19-1: Starting SimplePerf collector.
The command completed successfully.
LAB1E19-2: Getting list of counters.
LAB1E19-2: Applying filters.
LAB1E19-2: The following counters matched the specified filters:
LAB1E19-2: \\LAB1E19-2\Network Interface\*
LAB1E19-2: Creating SimplePerf collector, writing to C:\SimplePerf\220523081840.
The command completed successfully.

This allows the script to work properly on workstations.
Fixes #1075
@dpaulson45
Copy link
Copy Markdown
Member

An option as well is to not include the server's name in the counter. Similar to what we do for Exchange Daily Performance Logs:

image

vs

image

@bill-long
Copy link
Copy Markdown
Member Author

Investigating the no-computer-name approach.

@bill-long
Copy link
Copy Markdown
Member Author

bill-long commented May 23, 2022

I can't make the no-name approach work with a counter file. For example, if my counter file contains:

\Network Interface(*)\*

It doesn't collect anything. If prefixed with \\servername, then it does. The no-name approach does work with the -c parameter, but I'm hesitant to try to pass dozens of counter names as part of the command line.

@bill-long bill-long merged commit 17f831d into main May 23, 2022
@bill-long bill-long deleted the bilong-simpleperf branch May 23, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Issue] SimplePerf fails on workstations due to localhost

2 participants