Adjust autoupdate behavior#1127
Merged
Merged
Conversation
- Old script file is removed when update completes - Failures to download are now written as warnings, see comments
bill-long
force-pushed
the
bilong-autoupdate
branch
from
621c52f to
599a67a
Compare
dpaulson45
approved these changes
Jul 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note the small behavior change. If we are able to check for updates, but we then fail to either download or apply the update, we now write those failures as warnings. A failure to check is still silent (unless -Verbose is used) since we expect that to be normal in most cases.
Successful check but then download failed:
Successful check, download succeeded, but applying the update (renaming files, etc) failed: