Clean up text output#1173
Merged
Merged
Conversation
dpaulson45
approved these changes
Aug 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 of cleaning up the output.
It would be nice to remove all this text output and move it to Write-Progress until the final result. The prereq check does a great job of sending progress to Write-Progress, but the actual settings piece just sends text to the screen.
This PR makes the text better, but hopefully we can remove it and change all these Write-Host calls to Write-Verbose.
I also removed the 5 second pause. Pausing is not a good way to call attention to something. If we want to call more attention to something, put it at the bottom of the output, separate it with whitespace, and colorize it if necessary.
Before:
After: