Always use UTC for build number#1227
Merged
Merged
Conversation
dpaulson45
approved these changes
Sep 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use time-based build numbers which come from the latest commit for the script. The git log command which produces the time shows the time with time zone included.
We then [DateTime]::Parse(), this value. This produces a DateTime with type Local. So then we call DateTime.ToString(). At that point we're producing a string representing the local time. This causes the build number to change dependiing on the time zone of the machine.
With this change we always return a Universal time type, so build numbers are consistent across machines.