Update Get-HealthCheckFilesItemsFromLocation.ps1#1385
Merged
Conversation
A single xml report from a ExchangeDCCoreRatio broke the html report
This could be achieved with another $endname for the ExchangeDC-file like _{0}.txt so that -*-*.xml does not match anymore
Member
|
Build is failing due to: Please fix and then run |
fix formatting
Contributor
Author
|
Formatting fixed |
dpaulson45
approved these changes
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single xml report from a ExchangeDCCoreRatio broke the html report for me
This could be achieved with another $endname for the ExchangeDC-file like _{0}.txt so that --.xml does not match anymore
Issue:
A single xml report from a ExchangeDCCoreRatio run broke the html report for me
But that really could also be happened with a misnamed xml file, really
Reason:
Exempt the ExchangeDCCoreRatio xml files explicitely from being selected. We dont have any guess what other files are in there. But at least the files generated from our very own healthchecker should be taken care of.
Fix:
Short description of the fix
Narrowed down the selection of files,, probably doable otherwise if you guys have other preferences for exclusions.
Validation:
I manually tracked down what broke the creation and it came down to having 3 files for my 2 exchange boxes here. Excluded the ExchangeDCCoreRatio-File and everything was good again.
ExactErrorMessage
Cannot bind argument to parameter 'AnalyzeHtmlServerValues' because it is null.
... -AnalyzedHtmlServerValues $importData.HtmlServerValues