Skip to content

Update Get-HealthCheckFilesItemsFromLocation.ps1#1385

Merged
dpaulson45 merged 2 commits into
microsoft:releasefrom
stevecharon:patch-1
Dec 19, 2022
Merged

Update Get-HealthCheckFilesItemsFromLocation.ps1#1385
dpaulson45 merged 2 commits into
microsoft:releasefrom
stevecharon:patch-1

Conversation

@stevecharon
Copy link
Copy Markdown
Contributor

A single xml report from a ExchangeDCCoreRatio broke the html report for me
This could be achieved with another $endname for the ExchangeDC-file like _{0}.txt so that --.xml does not match anymore

Issue:
A single xml report from a ExchangeDCCoreRatio run broke the html report for me
But that really could also be happened with a misnamed xml file, really

Reason:
Exempt the ExchangeDCCoreRatio xml files explicitely from being selected. We dont have any guess what other files are in there. But at least the files generated from our very own healthchecker should be taken care of.

Fix:
Short description of the fix
Narrowed down the selection of files,, probably doable otherwise if you guys have other preferences for exclusions.

Validation:
I manually tracked down what broke the creation and it came down to having 3 files for my 2 exchange boxes here. Excluded the ExchangeDCCoreRatio-File and everything was good again.

ExactErrorMessage
Cannot bind argument to parameter 'AnalyzeHtmlServerValues' because it is null.
... -AnalyzedHtmlServerValues $importData.HtmlServerValues

A single xml report from a ExchangeDCCoreRatio broke the html report
This could be achieved with another $endname for the ExchangeDC-file like _{0}.txt so that -*-*.xml does not match anymore
@stevecharon stevecharon marked this pull request as ready for review December 19, 2022 16:37
@stevecharon stevecharon requested a review from a team as a code owner December 19, 2022 16:37
@bill-long
Copy link
Copy Markdown
Member

Build is failing due to:

RuleName                  Severity ScriptName                                Line Message
--------                  -------- ----------                                ---- -------
PSUseConsistentWhitespace Warning  Get-HealthCheckFilesItemsFromLocation.ps1 7    Use space before closing brace.

Please fix and then run .build\CodeFormatter.ps1 locally to confirm. Also, running CodeFormatter -Save might fix this for you. It can fix some problems automatically.

@stevecharon
Copy link
Copy Markdown
Contributor Author

Formatting fixed

@dpaulson45 dpaulson45 merged commit c250a8d into microsoft:release Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants