Release 1-9-2023

.build/CodeFormatter.ps1

@@ -5,8 +5,8 @@ param(
     [Switch]
     $Save,
 
-    [Switch]
-    $AllFiles
+    [string]
+    $Branch
 )
 
 #Requires -Version 7
@@ -32,14 +32,14 @@ if (-not (Load-Module -Name EncodingAnalyzer)) {
 
 $repoRoot = Get-Item "$PSScriptRoot\.."
 
-$optimizeCodeFormatter = $AllFiles -eq $false
+$optimizeCodeFormatter = [string]::IsNullOrEmpty($Branch) -eq $false
 $filesFullPath = New-Object 'System.Collections.Generic.HashSet[string]'
 # Get only the files that are changed in this PR
 if ($optimizeCodeFormatter) {
 
     Write-Verbose "Checking commits only"
-    # Get all the commits between origin/main and HEAD.
-    $gitlog = git log --format="%H %cd" --date=rfc origin/main..HEAD
+    # Get all the commits between origin/$Branch and HEAD.
+    $gitlog = git log --format="%H %cd" --date=rfc origin/$Branch..HEAD
     $m = $gitlog | Select-String "^(\S+) (.*)$"
 
     foreach ($commitMatch in $m) {
@@ -73,7 +73,7 @@ if ($optimizeCodeFormatter) {
 }
 
 if ($optimizeCodeFormatter) {
-    $filesToCheck = Get-ChildItem -Path $filesFullPath -Include "*.ps1", "*.psm1", "*.md"
+    $filesToCheck = $filesFullPath | Get-ChildItem -Include "*.ps1", "*.psm1", "*.md"
     Write-Host "Files that we are looking at for code formatting:"
     $filesToCheck.FullName | Write-Host
 } else {

.build/ValidateMerge.ps1

@@ -18,7 +18,9 @@
 #>
 
 [CmdletBinding()]
-param ()
+param (
+    [string]$Branch = "main"
+)
 
 $repoRoot = Get-Item "$PSScriptRoot\.."
 $distFolder = Join-Path $repoRoot "dist"
@@ -38,8 +40,8 @@ $allowMergeFiles = @()
 # Files we already checked. We only want to check each file once.
 $filesAlreadyChecked = New-Object 'System.Collections.Generic.HashSet[string]'
 
-# Get all the commits between origin/main and HEAD.
-$gitlog = git log --format="%H %cd" --date=rfc origin/main..HEAD
+# Get all the commits between origin/$Branch and HEAD.
+$gitlog = git log --format="%H %cd" --date=rfc origin/$Branch..HEAD
 $m = $gitlog | Select-String "^(\S+) (.*)$"
 
 foreach ($commitMatch in $m) {
@@ -85,7 +87,7 @@ foreach ($commitMatch in $m) {
     }
 
     foreach ($affectedFile in $allAffectedFiles) {
-        $commitTimeOnMainString = git log origin/main -n 1 --format="%cd" --date=rfc -- $affectedFile
+        $commitTimeOnMainString = git log origin/$Branch -n 1 --format="%cd" --date=rfc -- $affectedFile
         $commitTimeOnMain = $null
         if (-not [string]::IsNullOrEmpty($commitTimeOnMainString)) {
             $commitTimeOnMain = [DateTime]::Parse($commitTimeOnMainString).ToUniversalTime()

azure-pipeline-merge.yml

@@ -9,9 +9,11 @@ steps:
 
 - pwsh: |
     cd .\.build
-    .\CodeFormatter.ps1
+    .\CodeFormatter.ps1 -Branch $env:TargetBranchName
   displayName: "Code Formatting Script"
   condition: and(succeeded(), ne(variables['Build.SourceBranch'], 'refs/heads/release'))
+  env:
+    TargetBranchName: $(System.PullRequest.TargetBranch)
 
 - pwsh: |
     cd .\.build
@@ -25,5 +27,7 @@ steps:
 
 - pwsh: |
     cd .\.build
-    .\ValidateMerge.ps1
+    .\ValidateMerge.ps1 -Branch $env:TargetBranchName
   displayName: "Validate commit times"
+  env:
+    TargetBranchName: $(System.PullRequest.TargetBranch)

docs/PublicFolders/ValidateEXOPFDumpster.md

@@ -0,0 +1,78 @@
+# ValidateEXOPFDumpster
+
+Download the latest release: [ValidateEXOPFDumpster.ps1](https://github.com/microsoft/CSS-Exchange/releases/latest/download/ValidateEXOPFDumpster.ps1)
+
+This script investigates public folders/items deletion operations failures & propose FIXes for mitigation.
+The script is working to validate the below conditions over the affected public folder
+Checks run:
+-----------
+1.	Public folder size issue
+    a)	Public folder content mailbox TotalDeletedItemSize value has exceeded its RecoverableItemsQuota value
+    b)	Public folder size is full
+2.	User permissions are not synced between public folder mailboxes
+3.	Content Public folder mailbox across the public folder & its dumpster is different
+4.	EntryId & DumpsterEntryID values are not mapped properly on the public folder & its dumpster
+5.	Parent public folder dumpster is unhealthy
+6.	Dumpster folder
+7.	Dumpster folder has children
+8.  Mail-enabled public folder health if MEPFProxyGuid was null
+
+## Syntax
+
+```powershell
+ValidateEXOPFDumpster.ps1
+  [-Pfolder <string[]>]
+  [-Affecteduser <string[]>]
+  [-ExportPath <string[]>]
+```
+
+## Output
+
+The script will generate the public folder validation checks failures & proposed Fixes results on screen and will generate same results on ValidatePFDumpsterREPORT.txt file as well.
+There are other files generated for either script logging purposes or sometimes for logs to be shared with Microsoft personnel in case issues encountered requires microsoft support team intervention.
+
+File Name|Content|Use
+-|-|-
+ValidatePFDumpsterREPORT.txt|Information about any blockers found|The script will display what it found, and in many cases it will provide a mitigation to fix the problem
+ValidatePFDumpsterCheckslogging.csv|Information about the reason of script failure to run|The file will display errors encountered on running the script and at which stage
+PublicFolderInfo.xml|All required information about the affected public folder|This log file to be shared with Microsoft personnel
+
+## Usage
+
+Typically, the script should run with Pfolder identity parameter as illustrated below:
+
+```powershell
+.\ValidateEXOPFDumpster.ps1 -Pfolder \pf1
+```
+
+The script will prompt for affected public folder identity/EntryID if it wasn't provided using Pfolder parameter then it will prompt for global administrator username & password to connect to EXO by default it validates if the issue is specific to the Public folder "e.g. all users are affected"
+
+![Picture of script intro](PFDumps.jpg)
+![Picture of script intro without use Pfolder parameter](PFDumpswithoutparam.jpg)
+
+If the issue happens only with a specific user on that case an affected user smtp address is required to be provided
+
+![Picture of user specific issue type](PFDumps2.jpg)
+
+In this example output, the script calls out two blockers.
+
+It points out the below blockers:
+    Neither user nor Default user have sufficient permissions to delete items inside the public folder
+    Public folder size has exceeded Individual Public Folder ProhibitPostQuota value
+
+![Picture of example](PFDumps3.jpg)
+
+In this example output, the script calls out four blockers.
+
+It points out the below issues:
+    Public folder & its dumpster doesn't have the same content public folder mailbox
+    Public folder EntryId & DumpsterEntryID values are not mapped properly
+    Public folder size has exceeded Organization DefaultPublicFolderProhibitPostQuota value
+    Public folder dumpster has 1 subfolder
+
+The script created a log file containing all the required information "PublicFolderInfo.xml" to be shared with Microsoft personnel for the first two blockers & provided mitigation for the last two blockers and you can see same results under ValidatePFDumpsterREPORT.txt file.
+
+![Picture of example](PFDumps4.jpg)
+![Picture of Log files](PFDumps5.jpg)
+![Picture of Log file to Microsoft personnel](PFDumps6.jpg)
+

mkdocs.yml

@@ -66,6 +66,7 @@ nav:
   - PublicFolders:
     - SourceSideValidations: PublicFolders/SourceSideValidations.md
     - ValidateMailEnabledPublicFolders: PublicFolders/ValidateMailEnabledPublicFolders.md
+    - ValidateEXOPFDumpster: PublicFolders/ValidateEXOPFDumpster.md
   - Retention:
     - Get-MRMDetails: Retention/Get-MRMDetails.md
   - Search: