Skip to content

Adding Get-CalendarDiagnosticObjectsSummary.ps1#1471

Merged
dpaulson45 merged 12 commits into
microsoft:mainfrom
EnzoLopez2023:enzo-calendaring
Mar 9, 2023
Merged

Adding Get-CalendarDiagnosticObjectsSummary.ps1#1471
dpaulson45 merged 12 commits into
microsoft:mainfrom
EnzoLopez2023:enzo-calendaring

Conversation

@EnzoLopez2023
Copy link
Copy Markdown
Contributor

Issue:
This script runs the Get-CalendarDiagnosticObjects script and returns a summarized timeline of actions into clear english

Reason:
There's no script available on the repo to achieve this

Validation:
Have validated this script on a test environment and it's also being used as an internal tool

@EnzoLopez2023 EnzoLopez2023 requested a review from a team as a code owner January 29, 2023 21:13
@dpaulson45
Copy link
Copy Markdown
Member

@EnzoLopez2023 from now on, let's not close and open a new PR when we state we have changes. We have the ability to rebase the branch to clean up the commits if that is what you are worried about. It makes it harder for review otherwise.

@dpaulson45
Copy link
Copy Markdown
Member

Code formatting did not pass with the following:

image

Please address.

Comment thread Calendar/Get-CalendarDiagnosticObjectsSummary.ps1 Outdated
Comment thread Calendar/Get-CalendarDiagnosticObjectsSummary.ps1 Outdated
@dpaulson45
Copy link
Copy Markdown
Member

image

prior to commit, run .build\CodeFormatter.ps1 to make sure your commits aren't going to fail in the pipeline.

@EnzoLopez2023 EnzoLopez2023 requested a review from dpaulson45 March 9, 2023 13:02
@dpaulson45 dpaulson45 merged commit 16e6313 into microsoft:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants