Check for incorrect virtual directory path#1946
Merged
Merged
Conversation
Co-authored-by: Lukas Sassl <lusassl@microsoft.com>
lusassl-msft
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Because you can re-create the virtual directories, we need to verify the paths to make sure they are pointed to the correct default locations. Otherwise, they will not work as intended.
Reason:
Had a customer face this issue, easy enough to call out and avoid the cases.
Fix:
Check the last part of the path to make sure it is pointing to the correct location. Otherwise, then display an error.
Unable to use the Get cmdlets for the virtual directories because we are using
-ADPropertiesOnlywhich will not include the path. Therefore, we are basing this off the IISWebApplication information that we have collected.Resolved #1131
Validation:
Lab tested