first version bookings Helper by v-rusil · Pull Request #2197 · microsoft/CSS-Exchange

v-rusil · 2024-09-24T18:34:08Z

Issue:
Describe what the issue is you are addressing

Reason:
Describe what the reason is for making the change

Fix:
Short description of the fix

Validation:
Provide if applicable

Shanefe · 2024-09-24T20:02:55Z

function RunMessageTrackingLogTests {

Only comment would be if you wanted to rename from RunMessageTrackingLogTests to RunMessageTrackingLogValidation
i.e. use Validation instead of Test #Closed

Refers to: Calendar/BookingHelpers/BookingMessageTrackingLogLogic.ps1:1 in 204f797. [](commit_id = 204f797, deletion_comment = False)

Shanefe · 2024-09-24T20:15:23Z

function Get-StaffData {

This is in a Logic file, but looks more like a helper. #Closed

Refers to: Calendar/BookingHelpers/BookingStaffLogic.ps1:1 in 204f797. [](commit_id = 204f797, deletion_comment = False)

v-rusil · 2024-10-22T18:38:47Z

@microsoft-github-policy-service agree company="Microsoft"

dpaulson45 · 2024-10-22T18:40:48Z

/azp run

azure-pipelines · 2024-10-22T18:41:07Z

Azure Pipelines successfully started running 1 pipeline(s).

dpaulson45 · 2024-10-24T17:47:17Z

+    $BookingBusinessArray += [PSCustomObject]@{
+        DisplayName         = $GraphBookingBusiness.DisplayName
+        OwnerEmail          = $GraphBookingBusiness.Email
+        IsPublished         = $GraphBookingBusiness.IsPublished
+        DefaultCurrencyIso  = $GraphBookingBusiness.DefaultCurrencyIso
+        DefaultTimeZone     = $GraphBookingBusiness.DefaultTimeZone
+        LanguageTag         = $GraphBookingBusiness.LanguageTag
+        Phone               = $GraphBookingBusiness.Phone
+        PublicUrl           = $GraphBookingBusiness.PublicUrl
+        WebSiteUrl          = $GraphBookingBusiness.WebSiteUrl
+        CreatedDateTime     = $GraphBookingBusiness.AdditionalProperties["createdDateTime"]
+        lastUpdatedDateTime = $GraphBookingBusiness.AdditionalProperties["lastUpdatedDateTime"]
+        Address             = "City= " + $GraphBookingBusiness.Address.City + ", `r`n" +
+        "CountryOrRegion= " + $GraphBookingBusiness.Address.CountryOrRegion + ", `r`n" +
+        "PostalCode= " + $GraphBookingBusiness.Address.PostalCode + ", `r`n" +
+        "State= " + $GraphBookingBusiness.Address.State + ", `r`n" +
+        "Street= " + $GraphBookingBusiness.Address.Street
+    }


Shouldn't this be inside a loop? If you want the type to be returned an array, we should be able to create the object and define the type we want to be returned.

Not in this case, this method returns a 1 element array to be imported to Excel

Then we shouldn't be doing a += to make it an array element. Use the casting of [array] if that is what you want.

dpaulson45 · 2024-10-24T18:33:49Z

+            if ($PSCmdlet.ShouldProcess('Microsoft.Graph.Bookings module', 'Import')) {
+                Write-Verbose "Installing Microsoft.Graph.Bookings module..."
+
+                # Install Microsoft.Graph.Bookings module
+                Install-Module -Name Microsoft.Graph.Bookings -Force -AllowClobber
+
+                Write-Host "Done. Microsoft.Graph.Bookings module is now installed. Please re-run the script."


I agree that we need to likely do this. However, we should place it in Share somehow to avoid other scripts doing this same thing over and over again.

Need to think about this.

dpaulson45 · 2024-10-24T21:05:11Z

/azp run

azure-pipelines · 2024-10-24T21:05:23Z

Azure Pipelines successfully started running 1 pipeline(s).

dpaulson45 · 2024-10-25T14:04:53Z

Please add Prosumer here.

CSS-Exchange/.build/cspell-words.txt

Line 124 in a6be221

PROCMON

dpaulson45 · 2024-11-04T14:33:37Z

/azp run

azure-pipelines · 2024-11-04T14:33:49Z

Azure Pipelines successfully started running 1 pipeline(s).

dpaulson45 · 2024-11-04T15:33:32Z

/azp run

azure-pipelines · 2024-11-04T15:33:44Z

Azure Pipelines successfully started running 1 pipeline(s).

dpaulson45 · 2024-11-04T20:39:07Z

/azp run

azure-pipelines · 2024-11-04T20:39:17Z

Azure Pipelines successfully started running 1 pipeline(s).

v-rusil requested a review from a team as a code owner September 24, 2024 18:34

v-rusil marked this pull request as draft September 24, 2024 18:39