CalLogs - Switch to Prod code#2216
Merged
Merged
Conversation
dpaulson45
reviewed
Nov 6, 2024
dpaulson45
requested changes
Nov 6, 2024
dpaulson45
left a comment
dpaulson45
left a comment
Member
There was a problem hiding this comment.
Please try the one change I requested to make sure that works, if it does, change it up to make it easier to read.
I think the commits should be reduced down. If not 1 two should work, just don't like seeing a lot of individual commits in a single PR doing a fix of something.
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Extra Space ToString fix Remove annoying Warning on every Exception Fix checking for admin Move checking for admin up for better look. use -WarningAction SilentlyContinue
Shanefe
force-pushed
the
CalLogs-Use_Prod_Code
branch
from
8814776 to
f673644
Compare
dpaulson45
approved these changes
Nov 6, 2024
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Moving key functions into the Dev code. Switch script to using them.
Reason:
LogType --> LogRowType
client --> ShortClientInfoString
Validation:
Testing against Test tenants.