Skip to content

Addressing Computer Membership Unknown Issues with Remote Computer #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpaulson45 merged 1 commit into from
Nov 26, 2024
Merged

Addressing Computer Membership Unknown Issues with Remote Computer #2229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions Diagnostics/HealthChecker/Analyzer/Invoke-AnalyzerExchangeInformation.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,16 +305,24 @@ function Invoke-AnalyzerExchangeInformation {
Where-Object { $_.WellKnownName -in @("Exchange Trusted Subsystem", "Exchange Servers") }
$displayMissingGroups = New-Object System.Collections.Generic.List[string]

foreach ($localGroup in $localGroupList) {
if (($null -eq ($exchangeInformation.ComputerMembership.LocalGroupMember.SID | Where-Object { $_.ToString() -eq $localGroup.SID } ))) {
$displayMissingGroups.Add("$($localGroup.WellKnownName) - Local System Membership")
if ($null -ne $exchangeInformation.ComputerMembership.LocalGroupMember) {
foreach ($localGroup in $localGroupList) {
if (($null -eq ($exchangeInformation.ComputerMembership.LocalGroupMember.SID | Where-Object { $_.ToString() -eq $localGroup.SID } ))) {
$displayMissingGroups.Add("$($localGroup.WellKnownName) - Local System Membership")
}
}
} else {
$displayMissingGroups.Add("Unable to determine Local System Membership as the results were blank.")
}

foreach ($adGroup in $adGroupList) {
if (($null -eq ($exchangeInformation.ComputerMembership.ADGroupMembership.SID | Where-Object { $_.ToString() -eq $adGroup.SID }))) {
$displayMissingGroups.Add("$($adGroup.WellKnownName) - AD Group Membership")
if ($null -ne $exchangeInformation.ComputerMembership.ADGroupMembership) {
foreach ($adGroup in $adGroupList) {
if (($null -eq ($exchangeInformation.ComputerMembership.ADGroupMembership.SID | Where-Object { $_.ToString() -eq $adGroup.SID }))) {
$displayMissingGroups.Add("$($adGroup.WellKnownName) - AD Group Membership")
}
}
} else {
$displayMissingGroups.Add("Unable to determine AD Group Membership as the results were blank.")
}

if ($displayMissingGroups.Count -ge 1) {
Expand Down
25 changes: 20 additions & 5 deletions Diagnostics/HealthChecker/DataCollection/ExchangeInformation/Get-ExchangeInformation.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,16 +208,31 @@ function Get-ExchangeInformation {
if ($getExchangeServer.IsEdgeServer -eq $false) {
$params = @{
ComputerName = $Server
ScriptBlockDescription = "Getting Exchange Server Members"
ScriptBlockDescription = "Getting Exchange Server Local Group Members"
CatchActionFunction = ${Function:Invoke-CatchActions}
ScriptBlock = {
[PSCustomObject]@{
LocalGroupMember = (Get-LocalGroupMember -SID "S-1-5-32-544" -ErrorAction Stop)
ADGroupMembership = (Get-ADPrincipalGroupMembership (Get-ADComputer $env:COMPUTERNAME).DistinguishedName)
try {
$localGroupMember = Get-LocalGroupMember -SID "S-1-5-32-544" -ErrorAction Stop
} catch {
Write-Verbose "Failed to run Get-LocalGroupMember. Inner Exception: $_"
}
$localGroupMember
}
}
$computerMembership = Invoke-ScriptBlockHandler @params
$localGroupMember = Invoke-ScriptBlockHandler @params

# AD Module cmdlets don't appear to work in remote context with Invoke-Command, this is why it is now moved outside of the Invoke-ScriptBlockHandler.
try {
$adPrincipalGroupMembership = (Get-ADPrincipalGroupMembership (Get-ADComputer ($Server.Split(".")[0]) -ErrorAction Stop).DistinguishedName -ErrorAction Stop)
} catch {
# Current do not add Invoke-CatchActions as we want to be aware if this doesn't fix some things.
Write-Verbose "Failed to get the AD Principal Group Membership. Inner Exception: $_"
}

$computerMembership = [PSCustomObject]@{
LocalGroupMember = $localGroupMember
ADGroupMembership = $adPrincipalGroupMembership
}
}

[array]$serverMonitoringOverride = Get-MonitoringOverride -Server $Server
Expand Down