Computer Membership Fix update#2243
Merged
Merged
Conversation
Callout that we are missing a feature RSat-AD-PowerShell and have it installed.
dpaulson45
added
Issue
Health Checker
Do not merge
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lusassl-msft
previously approved these changes
Dec 5, 2024
Get-ADObject by default only searches the current domain when using Identity. Need to adjust to use the Filter and the GC port to find the objects we want.
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lusassl-msft
approved these changes
Dec 5, 2024
dpaulson45
removed
the
Do not merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
After the refactoring of Computer Memberships in PR #2229, we got more information about what is failing in customer's environment.
Reason:
Some computers didn't have the Active Directory PowerShell Module installed on the computer running the Health Checker, making this known and that it should be installed. The second is issue with
Get-ADPrincipalGroupMembershipstating it can't be run because the user isn't authenticated. Created some fallback logic to try to useGet-ADObjectinstead.Fix:
Callout that we don't have Active Directory Module installed and that we should have it installed in order to properly check this feature.
Have fallback logic to run
Get-ADObjectinstead for theMemberOffor the computer.Resolved #2242
Resolved #2239
Validation:
Lab tested/Pester tested/Pending customer confirmation