Use basic parsing for IWR.#301
Merged
Merged
Conversation
anshuldube
approved these changes
Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Download of Baselines fails if the Internet Explorer is not configured.
Reason:
Powershell uses parts of the Internet Explorer to parse responses of Invoke-WebRequest. For new accounts the Internet Explorer is possibly not configured.
Fix:
Add
-UseBasicParsingtoInvoke-WebRequestcalls. As the downloaded files are either plain text or Zip archives, no parsing whatsoever is required anyway.Validation:
Before:
After adding flag (there is still an error, because the zip file does not exist on Github; the connection test by downloading a text file succeeds):