Run Test-Path before Remove-Item to prevent Health Checker exception#516
Merged
bill-long merged 1 commit intoApr 23, 2021
Merged
Conversation
bill-long
approved these changes
Apr 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Health Checkers makes use of the new
Test-ScriptVersionfunction. In case an update is processed we're trying to remove an existingHealthChecker.ps1andHealthChecker.oldfile which may be there caused by previous update. In case there is noHealthChecker.ps1inTempand/or noHealthChecker.oldwe run into an error on HealthChecker (caused by how we handle errors in the script). We show the following:Reason:
This is caused by the
Remove-Itemcall against a non-existingHealthChecker.ps1and/or non-existingHealthChecker.oldfiles (update never happend before).Fix:
This can be easily avoided by running
Test-PathbeforeRemove-Item.Validation:
Validated in Lab. Possible Pester test case.