Skip to content

Display and rate signature hash algorithm (SHA) for Exchange certificates found on the system#592

Merged
dpaulson45 merged 2 commits into
mainfrom
lusassl-SHAwork
May 25, 2021
Merged

Display and rate signature hash algorithm (SHA) for Exchange certificates found on the system#592
dpaulson45 merged 2 commits into
mainfrom
lusassl-SHAwork

Conversation

@lusassl-msft
Copy link
Copy Markdown
Contributor

Description:
We are now displaying/rating the Signature Hash Algorithm for each Exchange certificate found on the system. We show a warning (yellow) if SHA-1 was used (because SHA-1 hash algorithm should be considered as weak).

Issue #589

Comment thread Diagnostics/HealthChecker/Analyzer/Invoke-AnalyzerEngine.ps1 Outdated
@lusassl-msft lusassl-msft requested a review from dpaulson45 May 20, 2021 13:15
https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-gpnap/a48b02b2-2a10-4eb0-bed4-1807a6d2f5ad
SignatureHashAlgorithmSecure = Unknown 0
SignatureHashAlgorithmSecure = Insecure/Weak 1
SignatureHashAlgorithmSecure = Secure 2
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the documentation on what is determined as secure or weak?

Copy link
Copy Markdown
Contributor Author

@lusassl-msft lusassl-msft May 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a link to a Microsoft location in the displayed results when we have a weak algorithm being used.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread Diagnostics/HealthChecker/Analyzer/Invoke-AnalyzerEngine.ps1 Outdated
https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-gpnap/a48b02b2-2a10-4eb0-bed4-1807a6d2f5ad
SignatureHashAlgorithmSecure = Unknown 0
SignatureHashAlgorithmSecure = Insecure/Weak 1
SignatureHashAlgorithmSecure = Secure 2
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a link to a Microsoft location in the displayed results when we have a weak algorithm being used.

format update

Wording changed
@dpaulson45 dpaulson45 merged commit f3a21c3 into main May 25, 2021
@dpaulson45 dpaulson45 deleted the lusassl-SHAwork branch May 25, 2021 17:29
@dpaulson45 dpaulson45 added Enhancement New feature or request Health Checker labels Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request Health Checker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants