Skip to content

Canthv0 simpleadmin#596

Merged
bill-long merged 9 commits into
mainfrom
canthv0-simpleadmin
May 25, 2021
Merged

Canthv0 simpleadmin#596
bill-long merged 9 commits into
mainfrom
canthv0-simpleadmin

Conversation

@Canthv0
Copy link
Copy Markdown
Contributor

@Canthv0 Canthv0 commented May 21, 2021

Issue:
Importing existing Get-SimpleAdminAuditlog script into github under a managed location.

Reason:
Moving the script to a proper location for maintaining.

@lusassl-msft
Copy link
Copy Markdown
Contributor

lusassl-msft commented May 21, 2021

It looks like this is failing due to formatting.
Please run .build\CodeFormatter.ps1 -Save from PS7 to auto-format, and manually fix the issues called out by PSScriptAnalyzer.

Copy link
Copy Markdown
Member

@bill-long bill-long left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The disclaimer should be removed. This is added by the build process to the released/signed script.

Also we generally do not declare authors in scripts, as these are intended to be collaborations. Anyone interested in determining authorship can examine the commit history.

@dpaulson45
Copy link
Copy Markdown
Member

The readme should also be moved to under docs.

@bill-long do we want this script under "Admin"?

@bill-long
Copy link
Copy Markdown
Member

Admin sounds fine. I'll push a commit to move the readme.

Comment thread Admin/Get-SimpleAuditLogReport.ps1 Outdated
# Build the result object to return our values
$Result | Add-Member -MemberType NoteProperty -Value $user -Name Caller
$Result | Add-Member -MemberType NoteProperty -Value $cmdlet -Name Cmdlet
$ResultResult | Add-Member -MemberType NoteProperty -Value $FullCommand -Name FullCommand
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is also a typo

@bill-long
Copy link
Copy Markdown
Member

This PR is still pending action from @Canthv0

  • Remove disclaimer and author
  • Fix typo identified by Lukas
  • Run CodeFormatter -Save to fix the build issues as noted by Lukas

@dpaulson45
Copy link
Copy Markdown
Member

@Canthv0 the script failed to match the formatting because of new requirement to have an empty line at the end of the file.

@Canthv0
Copy link
Copy Markdown
Contributor Author

Canthv0 commented May 25, 2021

Ok I think I have everything fixed now.

@bill-long bill-long merged commit 90e0a08 into main May 25, 2021
@bill-long bill-long deleted the canthv0-simpleadmin branch May 25, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants