Ensure dot sourced script paths use correct case#615
Merged
Conversation
dpaulson45
approved these changes
Jun 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
If a dot loaded script path has incorrect casing, we can't find the commit time of the file at build time. This causes build to fail with a somewhat vague error, which doesn't even tell you which embedded file failed, or why:
Reason:
Makes it hard to troubleshoot this build issue.
Fix:
Explicitly check the path case and throw a descriptive error. If the git log command fails for some other reason, still throw an error that at least calls out the file that failed. Output for the path case issue now looks like this: