Health Checker - Shared Files Updates#660
Merged
Merged
Conversation
Made sure they all had the dot loading files up at top and the Verbose information of 'Calling function name' was using `$($MyInvocation.MyCommand)`
Removed all the dot loading at the main script and only added them if they are used there.
bill-long
reviewed
Jul 30, 2021
lusassl-msft
requested changes
Jul 30, 2021
…ing it to class object by setting to a variable, it will return a `$null` and we can check against it. Then set the value and provide a verbose information that we changed it if need be.
Even though it is handled, we shouldn't be calling `GetValueKind()` if the key doesn't exist.
Avoid using bitwise operations
To avoid returning a large list of Exchange server for testing Exchange Management Shell, adding in an Identity parameter to pass. It is possible that the identity is not an Exchange Server, thus causing this to fail as if EMS is not loaded. This may cause misleading information in the end result. If we see an increase of question on the script(s) regarding this, will need to add in some logic to address it at that time.
lusassl-msft
requested changes
Aug 2, 2021
lusassl-msft
approved these changes
Aug 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did some major changes.
externdirectory fromDataCollectionSharedfiles the Health Checker uses to be using a better standardWrite-VerboseOutputfunction and are now just usingWrite-Verbose@lusassl-msft to also test before approving