Fix NIC settings fallback to WMI

[lusassl-msft]

Issue:
Fallback to WMI to query NIC settings was not working properly in some scenarios. If WMI was used to query the NIC settings, certain information was missing (IP addresses ...).

Reason:
There was no proper implementation to return the IP addresses in WMI scenario. We don't have all the information available which we get when using CIM with the latest cmdlets so this should be considered as a fallback just in case.

Fix:
Throw when we don't get any result via Get-NetworkConfiguration. Added some logic to get the IP addresses, subnet mask and gateway.

Validation:
Validated in lab and with affected customer. Please do not merge yet. Might require some more adjustments.

[dpaulson45]

While reviewing this code, looks like i found a major issue with the original code.

$adapterConfiguration is actually only defined in a foreach loop and we are call that same variable a few other times outside of that loop. Need to look at this more.

[lusassl-msft]

You mean this one?

#determine if IPv6 is enabled
$stopProcess = $false
foreach ($adapterConfiguration in $networkAdapterConfigurations) {
    $settingID = $adapterConfiguration.SettingID
    Write-Verbose "Working on '$($adapterConfiguration.Description)' | SettingID: $settingID"

    if ($settingID -eq $networkConfig.GUID -or
        $settingID -eq $networkConfig.InterfaceGuid) {
        foreach ($ipAddress in $adapterConfiguration.IPAddress) {
            if ($ipAddress.Contains(":")) {
                $ipv6Enabled = $true
                $stopProcess = $true
                break
            }
        }
    }

    if ($stopProcess) {
        break
    }
}

[dpaulson45]

Yep, that is the one.

[lusassl-msft]

I was wondering what this block was for. Think the $ipv6Enabled check could be done in the newly introduced logic below. Checked a few older versions of the script and it looks like the foreach was copied over from there.

[lusassl-msft]

Received feedback from customer that the WMI fallback works with the fix proposed.

[dpaulson45]

Except the code is written correctly, took a closer look at it last night and understood what was going on a little bit more. Will push out additional changes here today.