Skip to content

SourceSideValidations refactor#726

Merged
bill-long merged 37 commits into
mainfrom
bilong-ssvrefactor2
Sep 3, 2021
Merged

SourceSideValidations refactor#726
bill-long merged 37 commits into
mainfrom
bilong-ssvrefactor2

Conversation

@bill-long
Copy link
Copy Markdown
Member

@bill-long bill-long commented Sep 3, 2021 •
edited
Loading

This is a large refactoring of SourceSideValidations. Highlights:

  • Produces a single CSV file containing all the test results.
  • Includes a new test for problematic characters in folder names.
  • Includes a new test that checks for folders that are completely empty - that is, the folder itself has no items, all its children have no items, and all their children have no items, etc. These results are informational in nature, but they can be used to prune the hierarchy if desired.
  • If you forget what the script said in the results summary, such as what commands to run, you can use the -SummarizePreviousResults switch to re-summarize the last run.
  • Subsequent runs of the script do not overwrite the results. Instead, we rename the current file with its timestamp, and then we create a new ValidationResults.csv.
  • A -SlowTraversal option is now available for environments where there are so many folders that the normal approach times out. This option is slower, but it can recover from a disconnected PowerShell session.
  • Tests can be omitted by specifying the -Tests option. This is for scenarios where fixes have been performed and now you want to rerun only specific tests.

bill-long added 30 commits May 19, 2021 21:47
@bill-long
Refactor SourceSideValidations
5a1f736 
* Output all test results as objects
* Write all results to one file
* -ShowPreviousResults to read the file and re-summarize the results
* -SlowTraversal to traverse hierarchy one level at a time for very
  large hierarchies
* -Repair to read the results file and fix whatever we can fix.
  Currently only fixes bad permissions.
@bill-long
Resume after failure in SlowTraversal mode
3143a68
@bill-long
Use New-Object rather than ::new()
1a4ec55
@bill-long
Report errors during Get-ItemCount and retry
270e322
@bill-long
Report the hierarchy limits with the other results
5c67cc8
@bill-long
Recreate the session on retry and report empty folders
0a60eae
@bill-long
Tie up some loose ends
8c30e9b 
Abandon work on fixing things other than bad permissions. It's
making things very complicated. Maybe we can revisit that in
the future. For now, we're back to -RemoveInvalidPermissions to fix
the one thing we can. Otherwise, we're outputting basically the same
instructions as before on how to fix other problems.
@bill-long
Fix path depth calculation
7f32847
@bill-long
Adjust BadPermission result summary
f80773d
@bill-long
Send completed jobs to the pipeline
be59270
@bill-long
Multithreaded slow traversal item count
59aa05a
@bill-long
Preserve previous validation results
1e910be
@bill-long
Merge branch 'main' into bilong-ssvrefactor2
9b618f5
@bill-long
CodeFormatter fixes
32d2f4f
@bill-long
Merge branch 'main' into bilong-ssvrefactor2
b9463d1
@bill-long
Prevent unwanted output to pipeline
cef43be
@bill-long
Set debug config to interactive console for local debug
60d1c7d
@bill-long
Take pipeline input to New-TestResult
8262cfd
@bill-long
Merge branch 'main' into bilong-ssvrefactor2
860f6db
@bill-long
PSScriptAnalyzer fixes
a29a7f7
@bill-long
Remove the item count progress file
ec37d43
@bill-long
Add a little whitespace
23fb742
@bill-long
Add folder name check
a16ca56
@bill-long
Allow specifying which tests to run
ee2ebf4
@bill-long
Fix dumpster result bug
0a7c57e
@bill-long
Fix name result bug
e36366e
@bill-long
Accurately calculate folder path depth
d68f65a
@bill-long
Fix path depth calculation off by one
0b5ac77
@bill-long
Report folders that are completely empty including their subfolders
8e63842
@bill-long
Replace problem characters with spaces
851cccd
dpaulson45
dpaulson45 requested changes Sep 3, 2021
View reviewed changes
Comment thread PublicFolders/src/SourceSideValidations/Get-FolderData.ps1 Outdated
Comment thread PublicFolders/src/SourceSideValidations/Get-FolderData.ps1 Outdated
Comment thread PublicFolders/src/SourceSideValidations/Get-IpmSubtree.ps1
Comment thread PublicFolders/src/SourceSideValidations/Get-IpmSubtree.ps1 Outdated
Comment thread PublicFolders/src/SourceSideValidations/Get-ItemCountJob.ps1
Comment thread PublicFolders/src/SourceSideValidations/Get-ItemCountJob.ps1
Comment thread PublicFolders/src/SourceSideValidations/Tests/Name/Test-FolderName.ps1
@bill-long
Copy link
Copy Markdown
Member Author

bill-long commented Sep 3, 2021

Added the docs to this PR.

@dpaulson45 dpaulson45 self-requested a review September 3, 2021 19:50
@bill-long bill-long merged commit afcc8f1 into main Sep 3, 2021
@bill-long bill-long deleted the bilong-ssvrefactor2 branch September 3, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpaulson45 dpaulson45 dpaulson45 approved these changes

@lusassl-msft lusassl-msft Awaiting requested review from lusassl-msft

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bill-long @dpaulson45