Write down error when incorrect cores values are present#876
Merged
Conversation
Need to write a core error when over 24 cores for Exchange 2013 and 2016. Then over 48 cores when on Exchange 2019.
lusassl-msft
previously approved these changes
Jan 31, 2022
Decided to do a full check on this. Only needs to be done inside of the logic cores as you can't have more physical cores vs logical cores.
lusassl-msft
approved these changes
Jan 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
In the text file, we didn't state if something was wrong on Exchange 2016 when on 48 cores. Looking over the code, we just color code it as
Yellowand don't draw any attention to it.Reason:
On Exchange 2013 and 2016, if you have over 24 cores that is a problem. On Exchange 2019, if you have over 48 cores, that is also a problem that needs to be called out more clearly in the text files.
Fix:
Appended
- Errorwhen we are over the value per Exchange Server version and changed the display color to beRedinstead as it is an error.Resolved #848