Add SHA256 file hashes to release notes#912
Merged
Merged
Conversation
Member
|
It's intended for the CSV and TXT files to have the same data. You can use the CSV for programmatic verification and the TXT file for visual. So I think it would be better to generate the SHA256 hash when building the CSV and add a new column to the CSV to hold those values. Then when converting the CSV to TXT we add the new column. This way it's easy to verify the hash by script or other code - for example if we want our scripts that update themselves to start verifying hashes after downloading. |
Member
|
Oh, but it has to be after signing. I guess we need to generate the CSV, sign, then rewrite the CSV with hashes, then convert to TXT. |
Member
|
Pushed 2 lines of code to add the hash to CSV. |
Contributor
Author
|
Looks good. Should do the job. Thanks @bill-long |
dpaulson45
reviewed
Feb 25, 2022
dpaulson45
approved these changes
Feb 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Write out the SHA256 checksum for each script on the release page. We must create the file hash post script signing to make sure that the hash is accurate. We simply read the
ScriptVersions.csvfile which was created duringBuild.ps1run andoverwritecreate theScriptVersions.txtwhich was also initially created during Build.ps1 run. We also add the file hash to theScriptVersions.csv.